Confirmation for disabling feature doesn't always trigger

[rstawarz]

We had an issue in production where someone accidentally clicked the disable button when they shouldn't have. They reported there was no confirmation shown to warn them. I was able to recreate the issue in various scenarios. I think there's an issue with how the javascript enables the confirmation. I'm guessing there's an issue with the JS being applied the button. A couple suggestions:

• The button should be disabled until the confirmation click handler is enabled.
• the confirmation_text could be part of the submission to deactivating the flag to ensure this scenario can't occur.

https://github.com/user-attachments/assets/211422dd-c2db-4613-8e56-2f8751bae5bf

[jnunemaker]

I'll look into this. Thanks for the detailed report!

[jnunemaker]

@rstawarz should have this fix in next release this week.