zjsonpatch icon indicating copy to clipboard operation
zjsonpatch copied to clipboard

Automatic Module Name

Open fredrik-yttergren opened this issue 6 years ago • 3 comments

Hi. Thanks for an excellent library. I'm currently looking at migration from Java 8 to Java 11 in projects at work and am having issues relating to the module path, especially with the lack of automatic module name for this project. I understand the value of remaining compatible with Java 6, so would suggest that you add an Automatic-Module-Name entry to your manifest-file to make life easier for people using the module path as well as "reserving" a name for future reference.

I'm not well versed in Maven, but I think something like the below would work:

<plugin>
    <artifactId>maven-jar-plugin</artifactId>
    <version>2.4</version>
    <configuration>
        <archive>
            <manifestEntries>
                <Automatic-Module-Name>com.flipkart.zjsonpatch</Automatic-Module-Name>
            </manifestEntries>
        </archive>
    </configuration>
</plugin>

Cheers!

fredrik-yttergren avatar Nov 02 '18 11:11 fredrik-yttergren

Thanks, @fredrik-yttergren for bringing out the issue. Please allow me a couple of days to try and test it out ( since I haven't used Java 11 and need a bit of background before doing the requests change :) OR feel free to raise a PR )

vishwakarma avatar Nov 02 '18 13:11 vishwakarma

Sure, no worries, I'm just learning it myself right now by trial and error ;)

fredrik-yttergren avatar Nov 02 '18 13:11 fredrik-yttergren

This issue seems to persist in 2020 - any update on how to deal with it?

vab2048 avatar Dec 06 '20 01:12 vab2048