flip111

Results 333 comments of flip111

The test passes but i don't think it works correctly. Not sure what is happening

This is the first part to accept the new CLI option. How does it look so far?

I'd prefer snake case, but i don't mind too much either. So what will be the final decision? nate: snake thomas: snake jordan: camel f-f: undecided Is it like this...

Is an additional type with name `SubPackageConfig` needed? Similar to `PackageConfig` here https://github.com/purescript/spago/blob/master/core/src/Config.purs#L72-L81 The init commands takes the command line args and puts those in the `PackageConfig` https://github.com/purescript/spago/blob/master/src/Spago/Command/Init.purs#L48-L50 to support...

> I believe the logic we are using for inferring the bounds is correct I also think that is correct. But the rebuild is failing. To rebuild version 0.4.2 should...

Should [this](https://github.com/purescript/spago/blob/master/src/Spago/Command/Fetch.purs#L78) be called from [here](https://github.com/purescript/spago/blob/master/src/Spago/Command/Publish.purs#L339-L340)?

`Fetch.run` is only called from Main so far. And it doesn't take a package name as direct argument. Probably it's there in some reader/state monad. That's why i didn't know...

To run fetch with a different env than public i was thinking to use this function https://github.com/purescript/spago/blob/master/core/src/Prelude.purs#L73 That function takes an env, main makes such an env with this function...