flint icon indicating copy to clipboard operation
flint copied to clipboard

Clean up and document fft_small

Open fredrik-johansson opened this issue 2 years ago • 3 comments

fredrik-johansson avatar Apr 06 '23 20:04 fredrik-johansson

I've added basic documentation for machine_vectors.h. It's not clear what the assumptions are for some of the functions doing modular arithmetic.

fredrik-johansson avatar Apr 19 '23 11:04 fredrik-johansson

For example, what are the criteria for the initial prime p used in mpn_ctx_init? Seems like a necessary condition is $p > 2^{14}$. The first prime I can find here that works is 16567, but the following prime 16573 does not work.

albinahlback avatar Dec 13 '23 15:12 albinahlback

I should try to get into the habit of adding some comments whenever I figure out what some piece of fft_small does.

I added some explanations for the parameters in mpn_ctx_mpn_mul in 6879047.

fredrik-johansson avatar Mar 19 '24 14:03 fredrik-johansson