MangoHud icon indicating copy to clipboard operation
MangoHud copied to clipboard

Feature request: -Duse_system_imgui

Open Atemu opened this issue 2 years ago • 2 comments

Hi there, we at Nixpkgs currently need to hackily insert the imgui source into the build but we actually have it packaged natively.

Could you add a -Duse_system_imgui option like there is for spdlog? Thanks.

Atemu avatar May 17 '22 15:05 Atemu

On a second thought, it seems like imgui isn't discoverable by pkgconfig etc.

I really don't know enough about meson but I'd like to declare where a pre-built imgui can be found.

Atemu avatar May 17 '22 15:05 Atemu

It looks like this nixpkgs recipe merely copies some *.cpp (as well as *.h) files to {includedir}, I wonder how that's supposed to work at all?

eli-schwartz avatar May 17 '22 20:05 eli-schwartz

Is this still relevant?

flightlessmango avatar Jul 25 '23 12:07 flightlessmango

We need to hack deps into place anyhow, so this doesn't present much complexity.

Header/source deps need to be streamlined in general though. Any sane packaging process restricts internet access during the build and that means we all need to get these sources in through other means beforehand.

Atemu avatar Jul 25 '23 13:07 Atemu