MangoHud icon indicating copy to clipboard operation
MangoHud copied to clipboard

Benchmark displaying incorrect values

Open FireCulex opened this issue 2 years ago • 5 comments

2022-03-31_16-09

I have a log_duration of 90s. I open the CSV, sort from worst to best, average the first 9 values, I get 42 fps. MangoHud's displays 60. The other reason I think this is rather unlikely is Windows shows 44 fps for the 1%.

Same with 5%, average 45 of the worst values gives me 62 fps. Exactly inline with Windows results, but MangoHUD display shows 80.

FireCulex avatar Mar 31 '22 23:03 FireCulex

The fps values are averaged in 0.6.6 and earlier, it's been changed in master

flightlessmango avatar Mar 31 '22 23:03 flightlessmango

I assumed incorrectly I was on master, somehow I got switched onto develop. Thanks! 2022-03-31_16-32 Still displays bad 5% value, and if u notice when using using benchmark_percentiles= it shows 1% and 0.1% twice.

FireCulex avatar Mar 31 '22 23:03 FireCulex

Yeah I messed up a bit there, It will always show .1 and .01 percentiles, so you don't need to add those in the config. should be fixed either way.

are we sure the 5% value is incorrect? it's the 5th percentile, not 5 percent

flightlessmango avatar Apr 01 '22 00:04 flightlessmango

and if u notice when using using benchmark_percentiles= it shows 1% and 0.1% twice.

I missed that you were not setting anything, that seems like a clear bug, I will look into it

flightlessmango avatar Apr 01 '22 00:04 flightlessmango

are we sure the 5% value is incorrect? it's the 5th percentile, not 5 percent

You are right, we want the 5th percentile, not the 5% low.

100 seconds. 1000 rows. Sort A->Z. row 10 should be P1 and row 50 should be P5 yes? 2022-03-31_20-19

FireCulex avatar Apr 01 '22 03:04 FireCulex

Yes I think that's correct

flightlessmango avatar Jan 20 '23 02:01 flightlessmango

There has been changes to these parts a few times since, reopen if still an issue

flightlessmango avatar Dec 29 '23 10:12 flightlessmango