renative icon indicating copy to clipboard operation
renative copied to clipboard

[REGRESSION] templateAndroid child_value is not handled

Open locksten opened this issue 1 year ago • 0 comments

Describe the bug templateAndroid child_value is not placed inside the xml tag. Also, ResourceStrings in the react-native-maps plugin template should be updated to strings_xml. https://github.com/flexn-io/renative/blob/f0decfff7b474aa82929075485b880e3f6d31cf5/packages/config-templates/renative.templates.json#L2915-L2923

To Reproduce Run npx rnv configure -p android with a project that uses react-native-maps. platformBuilds/harness_android/app/src/main/res/values/strings.xml contains something like

<string
  name="google_maps_api_key"
  child_value="my-key"
/>

And if the app is built, child_value seems to be ignored by the merging process and it becomes

<string name="google_maps_api_key" />

Expected behavior The value should be inside the tag, like this:

<string name="google_maps_api_key">my-key</string>

Desktop:

  • RNV Version 1.0.0-rc.21

Additional context The child_value handling seems to have been removed here.

locksten avatar Aug 06 '24 14:08 locksten