renative icon indicating copy to clipboard operation
renative copied to clipboard

Published 20 hours ago • verified publisher icon flexn-io

Fix/android manifest generating

Open ElenaDiachenko opened this issue 11 months ago • 3 comments

Description

  • when generating androidManifest file rnv doesn’t take into account settings from plugins//androidTemplate section

Related issues

  • https://github.com/flexn-io/renative/issues/1435

Npm releases

n/a

ElenaDiachenko avatar Mar 04 '24 20:03 ElenaDiachenko

@ElenaDiachenko any way to test this?

pauliusguzas avatar Mar 05 '24 13:03 pauliusguzas

@pauliusguzas Check https://github.com/flexn-io/renative/issues/1435. I added settings to app-harness/renative.json/plugins/"react-native-photo-editor"/android/templateAndroid/AndroidManifest_xml.

If you run android and check platformBuilds/harness_android/app/src/main/AndroidManifest.xml you will see these activities and uses-permission being injected.

ElenaDiachenko avatar Mar 05 '24 14:03 ElenaDiachenko

@ElenaDiachenko I think we agreed that no testing will be done via code, test case on app-harness maybe should be added. cc @pavjacko @mihaiblaga89

pauliusguzas avatar Mar 05 '24 17:03 pauliusguzas