fcl icon indicating copy to clipboard operation
fcl copied to clipboard
verified publisher icon flexible-collision-library

Replace non-portable M_PI with constants::pi()

Open traversaro opened this issue 4 years ago • 3 comments

Similar to:

  • https://github.com/flexible-collision-library/fcl/pull/264
  • https://github.com/flexible-collision-library/fcl/pull/450

Problem originally experienced in https://github.com/conda-forge/fcl-feedstock/pull/11, but it seems it was also experienced in https://github.com/flexible-collision-library/fcl/issues/546 .

This change is Reviewable

traversaro avatar Nov 13 '21 14:11 traversaro

I am not sure why the problem was not detected in CI, I guess https://github.com/flexible-collision-library/fcl/issues/389 or something similar issue like https://github.com/flexible-collision-library/fcl/issues/442 . If there is interest in the fcl mantainers I would be happy to contribute and mantain a GitHub Actions-based CI script, either using conda-forge or vcpkg dependencies.

traversaro avatar Nov 13 '21 14:11 traversaro

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

sherm1 avatar Dec 21 '21 21:12 sherm1

@traversaro I see CI is not triggering for this and other PRs. Any thoughts on how to fix?

I am not sure. Perhaps it is the mitigation against mining for which mantainers need to manually allow CI jobs from PRs?

traversaro avatar Dec 21 '21 22:12 traversaro