tidy3d icon indicating copy to clipboard operation
tidy3d copied to clipboard

Published 20 hours ago • verified publisher icon flexcompute

:test_tube: TEST: Notebook and reproducible testing configurations refactor

Open daquinteroflex opened this issue 1 year ago • 3 comments

  • [X] tidy3d develop jupyterlab runs a jupyter lab environement within poetry
  • [x] tidy3d develop test full subcommand including refactored notebooks
  • [ ] Single notebook testing reproducible
  • [ ] Improved documentation on testing
  • [ ] Do we want to include these test scripts inside the dev testing action? Maybe not?

daquinteroflex avatar Feb 13 '24 16:02 daquinteroflex

@tylerflex I was thinking this could be a really good intro issue for Matt so he can also get familiar with the API and examples/physics. I am afraid what is the next step can be very repetitive since it involves manually selecting and saving the outputs of corresponding cells. I am happy to do this, but it would probably be pretty interesting for someone getting started with the tool. What do you think?

daquinteroflex avatar Apr 11 '24 11:04 daquinteroflex

@tylerflex I was thinking this could be a really good intro issue for Matt so he can also get familiar with the API and examples/physics. I am afraid what is the next step can be very repetitive since it involves manually selecting and saving the outputs of corresponding cells. I am happy to do this, but it would probably be pretty interesting for someone getting started with the tool. What do you think?

Sorry, could you remind me again what this PR is doing? Is the issue generally to come up with a set of reproducible testing environments for releases? It seems to me the main problem within this is a good way to do more automated testing of our notebook examples.

If you think it's better for Matt, that's ok, but maybe could you draft up a front end issue with some more details on what it is he should do?

tylerflex avatar Apr 11 '24 22:04 tylerflex

Whoops I am very sorry, I actually realised the issue I was referring to was:

https://github.com/flexcompute/tidy3d-notebooks/pull/43.

It was basically finishing setting up the testcases notebook unit tests I meant so we don't have to run all notebooks for every release. This one has just the scripts to run specific tests but I can finish this off.

I can write a set of instructions properly and I think it'll be a pretty good starting issue for Matt

daquinteroflex avatar Apr 12 '24 05:04 daquinteroflex