tidy3d icon indicating copy to clipboard operation
tidy3d copied to clipboard

`JaxSimulation.epsilon` ignores `input_structures`

Open tylerflex opened this issue 1 year ago • 2 comments

Another annoying case (like plot) where we need to convert to_simulation() first.

tylerflex avatar Feb 09 '24 13:02 tylerflex

Note for later: maybe when validating input_structures, we can just convert to regular Structure, add to structures, and then do everything else normally. Similar to how the permittivity_jax field works after the refactor.

tylerflex avatar Feb 09 '24 13:02 tylerflex

Somewhat related: seems JaxSimulationData.plot_field also doesn't work when applied to an output field monitor because JaxSimulation.get_monitor_by_name doesn't look in output_monitors.

I think I'll just try to do a refactor where the JaxSimulation input_structures and output_monitors are converted and appended to their structures and input_structures fields at init time and that should solve this and whatever other issues exist.

tylerflex avatar Feb 15 '24 18:02 tylerflex

fixed by #1601

tylerflex avatar Aug 02 '24 12:08 tylerflex