tidy3d
tidy3d copied to clipboard
flexcompute
Invalid link for `from_url` example in docs
In the docs page about the from_url class method, it lists an example page
This page can not be open in the browser, nor does it work when using it in the code
I'm a bit confused about where to find the correct link from refractiveindex.io in general. I can find links like https://refractiveindex.info/database/data-nk/main/Fe/Johnson.yml but it doesn't work for from_url either.
I see that there is a test for from_url in test_dispersion_fitter.py using some mock data. Maybe it's worth it to have another test using data directly from refractiveindex.io?
The link in the doc page is outdated: it should be https://refractiveindex.info/data_csv.php?datafile=database/data-nk/main/Ag/Johnson.yml
I'm a bit confused about where to find the correct link from refractiveindex.io in general. I can find links like https://refractiveindex.info/database/data-nk/main/Fe/Johnson.yml but it doesn't work for from_url either.
So the url is the link to a csv/txt file. For your Fe case, the url is https://refractiveindex.info/data_csv.php?datafile=database/data-nk/main/Fe/Johnson.yml
It seems like refractiveindex.io updates their website links from time to time.
When I click this [CSV - comma separated] button it directly downloads the csv file without opening a new page. Clicking the [Full database record] button does open a webpage with data. Does from_url work with this page?
When I click this [CSV - comma separated] button it directly downloads the csv file without opening a new page. Clicking the [Full database record] button does open a webpage with data. Does from_url work with this page?
The webpage you mentioned seems to be in yml format. So from_url doesn't work with it directly. Let me think about it how to support it.
just going through open issues. was this one ever fixed?
not yet, let me push a fix to update the URL