svelte-simple-modal icon indicating copy to clipboard operation
svelte-simple-modal copied to clipboard

2.0.1 svelte simple modal for Svelte5 Only Rune Mode

Open Neptunium1129 opened this issue 8 months ago • 1 comments
trafficstars

  • Svelte5 only Rune mode
  • add : function ContentOutside open Mode > Maximum update depth exceeded problem
  • edit : function bind : mount is maybe bug? detail is https://github.com/flekschas/svelte-simple-modal/issues/114
  • add : autofocus modal contents

Hi there 👋

Thank you so much for creating a PR. To streamline the process and make sure that your changes can get merged easily, please stick to the following structure. See #47 for an example of how to create an excellent PR description.

Background

Describe the context on how you use svelte-simple-modal. E.g., plain Svelte app, SvelteKit, Sapper, SSR, etc.

Currently Observed Behavior

  • detail is https://github.com/flekschas/svelte-simple-modal/issues/114
  • Bug Fix: mount was causing component duplication when repeatedly clicked.
  • mount was causing potential duplication issues when repeatedly clicking the button

New Behavior

  • Add: ContentOutside open mode - Prevents excessive updates, which were leading to a "Maximum update depth exceeded" error.
  • Add: Autofocus support for modal content - Ensures that modal elements receive focus when opened.

Neptunium1129 avatar Feb 22 '25 09:02 Neptunium1129