fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Published 20 hours ago • verified publisher icon fleetdm

Website: Update meta titles on pages built from markdown and social previews.

Open eashaw opened this issue 2 years ago • 3 comments

Related issue: https://github.com/fleetdm/confidential/issues/1608 Changes:

  • Changed the meta title of the handbook and documentation landing pages to be consistent with other pages
  • Updated the meta title of article pages to be consistent with our other pages.
  • Changed the layout of Twitter previews to be "summary_large_image" (https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary-card-with-large-image)

eashaw avatar Sep 14 '22 21:09 eashaw

@mikermcneil

@eashaw Could you link the issue this is related to?

Done! Sorry about that! This is the PR that updated these values on other pages: https://github.com/fleetdm/fleet/pull/7181

  1. This is what I would expect to see: https://github.com/fleetdm/fleet/blob/0a937b1a430f1662c5518d11e2090a394537f747/handbook/digital-experience/README.md#how-to-use-our-name

This is what we are using on our pageTitleForMeta values on other pages https://github.com/fleetdm/fleet/blob/1a781fca6f55d612658d5abdfeb8dc172b71d588/website/config/routes.js#L24 https://github.com/fleetdm/fleet/blob/1a781fca6f55d612658d5abdfeb8dc172b71d588/website/views/layouts/layout.ejs#L11

  1. I want to be sure that this isn't the solution we're relying on for fixing link unfurling elsewhere, e.g. on LinkedIn posts. Without the issue linked, I'm unsure about whether this is connected. To fix link unfurling for every social media platform, the solution is to server-render the relevant content.

This PR is unrelated to link unfurling, the metatags that use these values are server-rendered.

eashaw avatar Sep 21 '22 00:09 eashaw

@mikermcneil, we took lead from this comment for consistency's sake. To avoid future confusion, I've created a ticket to update the handbook.

mike-j-thomas avatar Sep 22 '22 01:09 mike-j-thomas

we took lead from https://github.com/fleetdm/fleet/pull/7181#issuecomment-1213472543 for consistency's sake. To avoid future confusion, I've created a https://github.com/fleetdm/fleet/issues/7891.

Yes, sorry for the confusion. We will stick with "Fleet for osquery". @eashaw @mike-j-thomas @chris-mcgillicuddy

mikermcneil avatar Sep 22 '22 19:09 mikermcneil

@mikermcneil @mike-j-thomas This PR has been updated to revert the meta title changes and the changes from https://github.com/fleetdm/fleet/pull/7181/

@mikermcneil Since this PR no longer makes any changes to any controllers, would you like me to remove you as a reviewer?

eashaw avatar Sep 29 '22 20:09 eashaw