fleet icon indicating copy to clipboard operation
fleet copied to clipboard

[WIP] 🤖 Attempted fix for #37168

Open iansltx opened this issue 4 weeks ago • 1 comments

Zed + Opus 4.5 pointed at the issue. Untested etc.

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • [ ] Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes. See Changes files for more information.

  • [ ] Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • [ ] Confirmed that the fix is not expected to adversely impact load test results
  • [ ] Alerted the release DRI if additional load testing is needed

Database migrations

  • [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • [ ] Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • [ ] Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • [ ] Verified that the setting is exported via fleetctl generate-gitops
  • [ ] Verified the setting is documented in a separate PR to the GitOps documentation
  • [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • [ ] Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • [ ] Verified compatibility with the latest released version of Fleet (see Must rule)
  • [ ] If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • [ ] Verified that fleetd runs on macOS, Linux and Windows
  • [ ] Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

iansltx avatar Dec 12 '25 23:12 iansltx

Codecov Report

:x: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.92%. Comparing base (76b6a25) to head (32fcf9f). :warning: Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
.../20251212225700_UpdateIdpSourceToMdmIdpAccounts.go 55.55% 3 Missing and 1 partial :warning:
server/datastore/mysql/hosts.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #37217    +/-   ##
========================================
  Coverage   65.92%   65.92%            
========================================
  Files        2329     2330     +1     
  Lines      184953   185224   +271     
  Branches     7707     7707            
========================================
+ Hits       121925   122118   +193     
- Misses      51883    51954    +71     
- Partials    11145    11152     +7     
Flag Coverage Δ
backend 67.73% <50.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 12 '25 23:12 codecov[bot]