fleet icon indicating copy to clipboard operation
fleet copied to clipboard

[WIP] Team labels work

Open iansltx opened this issue 4 weeks ago • 1 comments

Related issue: Resolves #

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • [ ] Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes. See Changes files for more information.

  • [ ] Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • [ ] Confirmed that the fix is not expected to adversely impact load test results
  • [ ] Alerted the release DRI if additional load testing is needed

Database migrations

  • [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • [ ] Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • [ ] Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • [ ] Verified that the setting is exported via fleetctl generate-gitops
  • [ ] Verified the setting is documented in a separate PR to the GitOps documentation
  • [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • [ ] Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • [ ] Verified compatibility with the latest released version of Fleet (see Must rule)
  • [ ] If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • [ ] Verified that fleetd runs on macOS, Linux and Windows
  • [ ] Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

iansltx avatar Dec 12 '25 20:12 iansltx

Codecov Report

:x: Patch coverage is 63.72951% with 177 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.87%. Comparing base (9adfe73) to head (f939b1b).

Files with missing lines Patch % Lines
server/datastore/mysql/labels.go 52.27% 91 Missing and 14 partials :warning:
server/service/labels.go 58.51% 27 Missing and 12 partials :warning:
frontend/services/entities/labels.ts 56.25% 7 Missing :warning:
...ManageLabelsPage/LabelsTable/LabelsTableConfig.tsx 40.00% 6 Missing :warning:
...d/fleetctl/fleetctl/testing_utils/testing_utils.go 72.72% 1 Missing and 2 partials :warning:
server/service/metrics_labels.go 0.00% 3 Missing :warning:
...ntend/pages/labels/EditLabelPage/EditLabelPage.tsx 66.66% 2 Missing :warning:
...s/components/DynamicLabelForm/DynamicLabelForm.tsx 33.33% 1 Missing and 1 partial :warning:
server/fleet/teams.go 50.00% 1 Missing and 1 partial :warning:
server/service/global_policies.go 88.88% 1 Missing and 1 partial :warning:
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #37208      +/-   ##
==========================================
- Coverage   65.91%   65.87%   -0.04%     
==========================================
  Files        2360     2361       +1     
  Lines      187170   187383     +213     
  Branches     7989     8017      +28     
==========================================
+ Hits       123366   123441      +75     
- Misses      52522    52645     +123     
- Partials    11282    11297      +15     
Flag Coverage Δ
backend 67.69% <63.25%> (-0.04%) :arrow_down:
frontend 54.40% <67.24%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 12 '25 20:12 codecov[bot]

@lucasmrod Going to stack additional tests in another PR since this one's massive. Added TODOs on where I believe we want more test coverage. Adding that checklist to the parent issue momentarily.

iansltx avatar Dec 24 '25 03:12 iansltx