fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Android software configuration: track status, verification

Open mna opened this issue 2 weeks ago • 3 comments

Related issue: Resolves #35515 and #35494

Checklist for submitter

  • [x] Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

Testing

mna avatar Dec 09 '25 15:12 mna

Codecov Report

:x: Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.98%. Comparing base (2765cde) to head (ae0318f). :warning: Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/vpp.go 77.77% 1 Missing and 1 partial :warning:
server/datastore/mysql/android.go 91.66% 1 Missing and 1 partial :warning:
server/worker/software_worker.go 88.23% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36966      +/-   ##
==========================================
+ Coverage   65.95%   65.98%   +0.02%     
==========================================
  Files        2336     2273      -63     
  Lines      185738   185264     -474     
  Branches     7854     7720     -134     
==========================================
- Hits       122509   122243     -266     
+ Misses      52036    51832     -204     
+ Partials    11193    11189       -4     
Flag Coverage Δ
backend 67.76% <88.46%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 09 '25 16:12 codecov[bot]

Oh, one very important/useful thing I should mention if you need to run more tests and investigate the pub-sub report, you can uncomment those lines and have the report saved under a unique name for each report you receive (you will often receive multiple pub-sub reports for the same policy version, e.g. one that might say app is "INSTALLING" and one that says it has been "INSTALLED"): https://github.com/fleetdm/fleet/blob/5539edd854e6df9bd46c400443ae565f90a66bf0/server/mdm/android/service/pubsub.go#L120-L126

mna avatar Dec 10 '25 20:12 mna

One more thing that will need to be addressed, I just reviewed this PR by @jahzielv and it adds a new Android worker task: https://github.com/fleetdm/fleet/pull/37062#discussion_r2608110652

This PR is targeting the RC that doesn't have android app configuration in, but once it lands in main, it will have to be updated to take android app configurations into account when it calls the AMAPI endpoint. (similarly to the other, existing bulk-set apps task: https://github.com/fleetdm/fleet/blob/15a39bd647635af2a5f2aeff6a3a0b94764dc26f/server/worker/software_worker.go#L320-L343).

mna avatar Dec 10 '25 20:12 mna