fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Activity bounded context

Open getvictor opened this issue 1 month ago • 1 comments

Related issue: NA

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • [ ] Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes. See Changes files for more information.

  • [ ] Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

For unreleased bug fixes in a release candidate, one of:

  • [ ] Confirmed that the fix is not expected to adversely impact load test results
  • [ ] Alerted the release DRI if additional load testing is needed

Database migrations

  • [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration.
  • [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • [ ] Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

New Fleet configuration settings

  • [ ] Setting(s) is/are explicitly excluded from GitOps

If you didn't check the box above, follow this checklist for GitOps-enabled settings:

  • [ ] Verified that the setting is exported via fleetctl generate-gitops
  • [ ] Verified the setting is documented in a separate PR to the GitOps documentation
  • [ ] Verified that the setting is cleared on the server if it is not supplied in a YAML file (or that it is documented as being optional)
  • [ ] Verified that any relevant UI is disabled when GitOps mode is enabled

fleetd/orbit/Fleet Desktop

  • [ ] Verified compatibility with the latest released version of Fleet (see Must rule)
  • [ ] If the change applies to only one platform, confirmed that runtime.GOOS is used as needed to isolate changes
  • [ ] Verified that fleetd runs on macOS, Linux and Windows
  • [ ] Verified auto-update works from the released version of component to the new version (see tools/tuf/test)

getvictor avatar Dec 07 '25 14:12 getvictor

Codecov Report

:x: Patch coverage is 37.45318% with 501 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.97%. Comparing base (ae66a83) to head (8a06e68). :warning: Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
server/activity/internal/mysql/activity.go 0.00% 333 Missing :warning:
server/datastore/mysql/common_mysql/sql_helpers.go 0.00% 47 Missing :warning:
server/activity/service/endpoint_utils.go 0.00% 24 Missing :warning:
server/activity/service/service.go 21.42% 21 Missing and 1 partial :warning:
server/contexts/ctxerr/ctxerr.go 53.33% 14 Missing :warning:
server/platform/http/errors.go 87.00% 11 Missing and 2 partials :warning:
server/activity/service/handler.go 0.00% 12 Missing :warning:
cmd/fleet/serve.go 0.00% 11 Missing :warning:
server/activity/activity.go 0.00% 5 Missing :warning:
server/contexts/ctxerr/metadata.go 81.81% 4 Missing :warning:
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36844      +/-   ##
==========================================
+ Coverage   65.91%   65.97%   +0.05%     
==========================================
  Files        2259     2149     -110     
  Lines      184211   183378     -833     
  Branches     7646     7403     -243     
==========================================
- Hits       121430   120978     -452     
+ Misses      51695    51324     -371     
+ Partials    11086    11076      -10     
Flag Coverage Δ
android ?
backend 67.53% <37.45%> (-0.18%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 07 '25 14:12 codecov[bot]