fleet
fleet copied to clipboard
Add Company Portal for macOS as a Fleet-mainted app
With the upcoming release of our Microsoft compliance partnership, this will make deploying the Company Portal app easier for admins.
@mostlikelee I see that this PR was approved by Lucas. Not sure what is supposed to be done now? cc @noahtalerman
@allenhouchins Please create an associated issue so that QA doesn't miss this when testing the release.
@allenhouchins Thanks for opening this PR. Attached, please find an SVG of the app icon. Please add this to the PR like so, and update the index.ts file like this.
FYI @mostlikelee
@mostlikelee as per our testing steps, can you please check that the name for the new app matches the name that shows up in Fleet's software inventory? And generate the outputs/apps.json file.
@noahtalerman
Q1: The icon for VPP app is white background. Do you want me to make the icon background white in the Fleet icons library? Q2: The name for the VPP app version is "Intune Company Portal" which shows up in the VPP app library. Do we want to be consistent with that?
Notes: Looks like they don't have macOS version on VPP
Screenshot is of adding "Intune Company Portal from ABM and what shows up in the VPP App UI:
Notes: Downloading manually from Homebrew returns the name "Company Portal"
Screen recording of what is shown when downloaded manually (blue icon is fleet icon created from SVG above): https://github.com/user-attachments/assets/8048a4f9-162b-4087-9808-802337ca949e
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 64.18%. Comparing base (
1528da6) to head (1239d8f). Report is 2 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...twarePage/components/icons/IntuneCompanyPortal.tsx | 50.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #29777 +/- ##
==========================================
- Coverage 64.18% 64.18% -0.01%
==========================================
Files 1888 1889 +1
Lines 185001 185003 +2
Branches 5406 5324 -82
==========================================
- Hits 118752 118748 -4
- Misses 56915 56921 +6
Partials 9334 9334
| Flag | Coverage Δ | |
|---|---|---|
| frontend | 53.51% <50.00%> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Per @noahtalerman during DR 6/26
- Changing name to "Intune Company Portal" to match VPP app name
- Changing icon to have a white background to match VPP app icon
Per step 4 and 6 in ee/maintained-apps/README.md#testing
This is ready for you @eashaw and @jmwatts -- I assigned y'all <3
[!IMPORTANT]
Review skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yamlfile in this repository. To trigger a single review, invoke the@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
📝 Walkthrough
Walkthrough
A new maintained application, "Intune Company Portal" for macOS, has been integrated. This includes its metadata, manifest, installation and uninstallation scripts, an entry in the maintained apps list, and a new SVG icon component with a mapping in the frontend icon registry.
Changes
| File(s) | Change Summary |
|---|---|
| ee/maintained-apps/inputs/homebrew/intune-company-portal.json | Added JSON config with metadata for Intune Company Portal app |
| ee/maintained-apps/outputs/apps.json | Added Intune Company Portal entry for Darwin (macOS) |
| ee/maintained-apps/outputs/intune-company-portal/darwin.json | New manifest for Intune Company Portal, including install/uninstall scripts and app metadata |
| frontend/pages/SoftwarePage/components/icons/IntuneCompanyPortal.tsx | Added new React SVG icon component for Intune Company Portal |
| frontend/pages/SoftwarePage/components/icons/index.ts | Added mapping for "company portal" to the new icon in the icon map |
Sequence Diagram(s)
sequenceDiagram
participant User
participant Frontend
participant MaintainedApps
participant System
User->>Frontend: Requests Software Page
Frontend->>MaintainedApps: Loads app metadata (apps.json)
MaintainedApps-->>Frontend: Provides Intune Company Portal entry
Frontend->>Frontend: Maps "company portal" to IntuneCompanyPortal icon
Frontend-->>User: Renders Software Page with icon and metadata
User->>System: Triggers install/uninstall for Intune Company Portal
System->>MaintainedApps: Reads manifest (darwin.json)
MaintainedApps->>System: Provides install/uninstall scripts
System->>System: Executes install/uninstall as per manifest
Poem
A portal hops into the fold,
With scripts and icons, shiny and bold.
Mac users cheer, their apps in line—
Company Portal works just fine!
SVGs sparkle, scripts deploy,
Rabbits bounce with techy joy.
🐇✨
✨ Finishing Touches
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
- [ ] Commit unit tests in branch
allenhouchins-add-company-portal-as-fma
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai auto-generate unit teststo generate unit tests for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@allenhouchins This is also no longer mergeable so I'm setting to draft. Reminder to check your open PRs. Thanks!
Assigning to @mostlikelee per Slack conversation.