fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Add LastPass for macOS as a Fleet-maintained app

Open allenhouchins opened this issue 6 months ago • 5 comments

  • Adding LastPass for macOS as a Fleet-maintained app

allenhouchins avatar Jun 04 '25 15:06 allenhouchins

@mostlikelee @noahtalerman

Looks like the automation that assigns this to me is still running, but I believe this is on hold atm?

eugkuo avatar Jun 04 '25 15:06 eugkuo

Looks like the automation that assigns this to me is still running, but I believe this is on hold atm?

@eugkuo @mostlikelee we decided to get new Fleet-maintained apps tested and merged! Please take as shot at running through our testing steps so we can ship this app 🚀

Updates to existing apps are on hold until we split out PRs for updates: https://github.com/fleetdm/fleet/issues/29218

noahtalerman avatar Jun 05 '25 16:06 noahtalerman

@allenhouchins Thanks for adding this new app. Attached, please find an SVG of the app icon. Please add this to the PR like so, and update the index.ts file like this.

Thanks! cc @mostlikelee

lastpass-icon

eugkuo avatar Jun 18 '25 19:06 eugkuo

UPDATE: @noahtalerman: DONE. I added back the outputs/apps.json file.


Whoops! I meant to remove the changes from the outputs/apps.json file. Not the entire file. Working on adding that file back...

Did the same thing in another PR. Here's why: https://github.com/fleetdm/fleet/pull/29806#issuecomment-2992044445

noahtalerman avatar Jun 20 '25 15:06 noahtalerman

@mostlikelee as per our testing steps, can you please check that the name for the new app matches the name that shows up in Fleet's software inventory? And generate the outputs/apps.json file.

noahtalerman avatar Jun 20 '25 15:06 noahtalerman

Looks good

https://github.com/user-attachments/assets/e00a1379-78ce-4caf-a6d3-78ba9b68c935

Screenshot 2025-06-26 at 10 44 23 AM

RachelElysia avatar Jun 26 '25 14:06 RachelElysia

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.22%. Comparing base (6143762) to head (542a764). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...d/pages/SoftwarePage/components/icons/LastPass.tsx 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29752      +/-   ##
==========================================
- Coverage   64.22%   64.22%   -0.01%     
==========================================
  Files        1869     1870       +1     
  Lines      182890   182892       +2     
  Branches     5285     5368      +83     
==========================================
+ Hits       117454   117455       +1     
- Misses      56225    56226       +1     
  Partials     9211     9211              
Flag Coverage Δ
frontend 54.50% <50.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 26 '25 14:06 codecov[bot]

Per step 4 and 6 in ee/maintained-apps/README.md#testing

This is ready for you @eashaw and @jmwatts -- I assigned y'all <3

RachelElysia avatar Jun 26 '25 16:06 RachelElysia

@allenhouchins This PR is no longer mergeable so I'm setting to draft. Reminder to check your open PRs. Thanks!

lukeheath avatar Jul 11 '25 20:07 lukeheath

Assigning to @mostlikelee per Slack conversation.

allenhouchins avatar Jul 12 '25 02:07 allenhouchins