Incorrect software title name (MacFULL) when uploading SubEthaEdit

[iansltx]

Fleet version: <= 4.63.0

---

💥  Actual behavior

Package shows as MacFULL

🧑‍💻  Steps to reproduce

Upload SubEthaEdit as a custom package.

🕯️ More info

Split from #24873, as the package structure for this installer is different from SentinelOne and Cold Turkey, so the fix for those packages doesn't work here.

[iansltx]

Hey team! Please add your planning poker estimate with Zenhub @jahzielv @ksykulev

[mostlikelee]

timebox - we may not have data to use

[jmwatts]

Another unexpected naming scenario: this package uploads as "trial" https://drive.google.com/file/d/16UdYLIENNcFNBstrtBTl4ZHiLFe9-qDB/view?usp=drive_link

[iansltx]

Looks like there's a quick fix for this, as the app has an install path: if the install path ends with .app, grab that install path and use it as the name:

~/code/fleet main $ go run tools/custom-package-parser/main.go -path /Users/ian/Downloads/SubEthaEdit-5.2.4.pkg 
- Name: 'SubEthaEdit'
- Bundle Identifier: 'de.codingmonkeys.SubEthaEdit.MacFULL'
- Package IDs: 'SEEMode.ActionScript,SEEMode.Base,SEEMode.C,SEEMode.CPP,SEEMode.CSS,SEEMode.Conference,SEEMode.Diff,SEEMode.EEx,SEEMode.ERB,SEEMode.Elixir,SEEMode.Erlang,SEEMode.HTML,SEEMode.JSON,SEEMode.Java,SEEMode.Javascript,SEEMode.LaTeX,SEEMode.Lua,SEEMode.Markdown,SEEMode.Objective-C,SEEMode.PHP-HTML,SEEMode.Perl,SEEMode.Python,SEEMode.Ruby,SEEMode.Swift,SEEMode.TOML,SEEMode.XML,SEEMode.bash,SEEMode.go,SEEMode.wren,de.codingmonkeys.SubEthaEdit.SeeTextImporterFULL,de.monkeydom.TCMPortMapper,isao.sonobe.OgreKit,org.mozilla.universalchardet,org.sparkle-project.InstallerConnection,org.sparkle-project.InstallerLauncher,org.sparkle-project.InstallerStatus,org.sparkle-project.Sparkle,org.sparkle-project.Sparkle.Updater'
- Version: 5.2.4

[iansltx]

The fix included here also handles the Pixelmator Pro Trial nicely:

~/code/fleet 25587-pkg-name-extraction $ go run tools/custom-package-parser/main.go -path /Users/ian/Downloads/PixelmatorProTrial_3.6.14.pkg 
- Name: 'Pixelmator Pro Trial'
- Bundle Identifier: 'com.pixelmatorteam.pixelmator.x.trial'
- Package IDs: 'com.pixelmator.PXMEngine,com.pixelmator.pixelmatorteam.LibRaw,com.pixelmator.pixelmatorteam.PDFEngine,com.pixelmator.pixelmatorteam.PSDEngine,com.pixelmator.pixelmatorteam.SVGEngine,com.pixelmatorteam.PTFoundation,com.pixelmatorteam.PTImageIO,com.pixelmatorteam.PTPaintTools,com.pixelmatorteam.PTPhotoKit,com.pixelmatorteam.extended-raw-support,com.pixelmatorteam.pixelmator.PXMKit,com.pixelmatorteam.pixelmator.object-removal,com.pixelmatorteam.pixelmator.paint-selection,com.pixelmatorteam.pixelmator.x.PXMPhotoKitUI,com.pixelmatorteam.pixelmator.x.PXMUIKit,com.pixelmatorteam.pixelmator.x.automator.apply-color-adjustments-to-images,com.pixelmatorteam.pixelmator.x.automator.apply-effects-to-images,com.pixelmatorteam.pixelmator.x.automator.auto-enhance-images,com.pixelmatorteam.pixelmator.x.automator.auto-white-balance-images,com.pixelmatorteam.pixelmator.x.automator.change-type-of-images,com.pixelmatorteam.pixelmator.x.automator.denoise-images,com.pixelmatorteam.pixelmator.x.automator.increase-resolution-of-images,com.pixelmatorteam.pixelmator.x.automator.scale-images,com.pixelmatorteam.pixelmator.x.automator.trim-images,com.pixelmatorteam.pixelmator.x.pxmspotlight,com.pixelmatorteam.pixelmator.x.trial.PXMPro,com.pixelmatorteam.pixelmator.x.trial.photos-extension,com.pixelmatorteam.pixelmator.x.trial.quicklookpreviewextension,com.pixelmatorteam.pixelmator.x.trial.remove-background,com.pixelmatorteam.pixelmator.x.trial.thumbnailextension,com.revenuecat.Purchases'
- Version: 3.6.14

[jmwatts]

QA Notes

Uploaded SubEthaEdit and Pixelmator ProTrial. Names are much more reflective of the software that was uploaded.

NOTE: If the software has been previously uploaded, the name will still be wrong until the installer has been deleted from all teams and the corresponding row in software_titles has been removed from the database. Once that's done and the package is re-uploaded, the name will be the corrected one.

[fleet-release]

SubEthaEdit uploads, Fleet now speaks its true name, Clarity in clouds.