fleet icon indicating copy to clipboard operation
fleet copied to clipboard

fleet-gitops flow is broken for free users (and some premium users)

Open getvictor opened this issue 1 year ago • 1 comments

I tried following the flow from https://github.com/fleetdm/fleet-gitops using a non-premium Fleet deploy on Render, and hit these issues:

  • The fleet-gitops flow does not work without a ./teams directory or files in the ./teams directory
  • --delete-other-teams switch does not work for free users -- it should be ignored for non-premium users

TODO after release

getvictor avatar Oct 21 '24 15:10 getvictor

fleet-gitops PR: https://github.com/fleetdm/fleet-gitops/pull/55/files

getvictor avatar Oct 21 '24 15:10 getvictor

QA Notes:

I reproduced the undesired error on 4.58.0 -

fleetctl gitops --context=preview -f ~/fleetdm/gitops_configs/default.yml --delete-other-teams                06:56:44 PM
Warning: Version mismatch.
Client Version:  4.54.0
Server Version: 0.0.0-SNAPSHOT-e98f86d
[+] applied fleet config
[+] applied enroll secrets
Error: missing or invalid license

and confirmed once the fix was applied the --delete-other-teams tag was ignored in the free version of preview

fleetctl gitops --context=preview -f ~/fleetdm/gitops_configs/default.yml --delete-other-teams        06:35:53 PM
Warning: Version mismatch.
Client Version:  tf-mod-byo-ecs-v1.8.1-135-g1172f8815-dirty
Server Version: 0.0.0-SNAPSHOT-1172f88
[+] applied fleet config
[+] applied enroll secrets
[!] gitops succeeded

PezHub avatar Nov 07 '24 15:11 PezHub

In cloud city's code, Fleet-gitops flow now mends, Free users find road.

fleet-release avatar Nov 12 '24 17:11 fleet-release