fleet icon indicating copy to clipboard operation
fleet copied to clipboard

SE: CLI setup experience changes

Open mna opened this issue 1 year ago • 1 comments

#22385

Checklist for submitter

  • [ ] Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes. See Changes files for more information.
  • [ ] Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • [ ] Added/updated tests
  • [ ] Manual QA for all new/changed functionality

mna avatar Oct 16 '24 15:10 mna

Codecov Report

Attention: Patch coverage is 54.12844% with 150 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-setup-experience@aaea56d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/service/client.go 51.85% 61 Missing and 17 partials :warning:
server/service/client_scripts.go 12.90% 54 Missing :warning:
server/datastore/mysql/software_installers.go 76.00% 4 Missing and 2 partials :warning:
ee/server/service/teams.go 33.33% 3 Missing and 1 partial :warning:
server/fleet/app.go 42.85% 3 Missing and 1 partial :warning:
server/fleet/teams.go 55.55% 3 Missing and 1 partial :warning:
Additional details and impacted files
@@                   Coverage Diff                    @@
##             feat-setup-experience   #22956   +/-   ##
========================================================
  Coverage                         ?   63.13%           
========================================================
  Files                            ?     1546           
  Lines                            ?   146433           
  Branches                         ?     3644           
========================================================
  Hits                             ?    92451           
  Misses                           ?    46655           
  Partials                         ?     7327           
Flag Coverage Δ
backend 64.00% <54.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 21 '24 19:10 codecov[bot]

Note that there are no automated gitops tests for the new feature in this PR, I'll add those in a subsequent PR tomorrow (it has been manually tested). Also, setting the VPP apps to install during setup is not implemented for "No team" because VPP apps are not supported for "No team" at the moment - this ticket will track this (released AFAIK) bug: https://github.com/fleetdm/fleet/issues/22970

mna avatar Oct 22 '24 20:10 mna

Automated tests added in https://github.com/fleetdm/fleet/pull/23125

mna avatar Oct 23 '24 15:10 mna