SE: CLI setup experience changes
#22385
Checklist for submitter
- [ ] Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes. See Changes files for more information. - [ ] Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added/updated tests
- [ ] Manual QA for all new/changed functionality
Codecov Report
Attention: Patch coverage is 54.12844% with 150 lines in your changes missing coverage. Please review.
Please upload report for BASE (
feat-setup-experience@aaea56d). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## feat-setup-experience #22956 +/- ##
========================================================
Coverage ? 63.13%
========================================================
Files ? 1546
Lines ? 146433
Branches ? 3644
========================================================
Hits ? 92451
Misses ? 46655
Partials ? 7327
| Flag | Coverage Δ | |
|---|---|---|
| backend | 64.00% <54.12%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note that there are no automated gitops tests for the new feature in this PR, I'll add those in a subsequent PR tomorrow (it has been manually tested). Also, setting the VPP apps to install during setup is not implemented for "No team" because VPP apps are not supported for "No team" at the moment - this ticket will track this (released AFAIK) bug: https://github.com/fleetdm/fleet/issues/22970
Automated tests added in https://github.com/fleetdm/fleet/pull/23125