fleet icon indicating copy to clipboard operation
fleet copied to clipboard

"Delete host" modal: Add link for "revoke the host's enroll secret"

Open mikermcneil opened this issue 4 years ago • 5 comments

Goal

As a user trying to delete a host, I want to know how I can revoke the host's enroll secret.

image

How?

  • [ ] Make sure a doc page section or FAQ answer exists in the Fleet docs about this
  • [ ] Consider rephrasing to "revoke the enroll secret used by this host"
  • [ ] Add link to fleetdm.com/docs/… pointed at the relevant doc page section or FAQ answer

mikermcneil avatar Sep 10 '21 20:09 mikermcneil

related to https://github.com/fleetdm/fleet/issues/1364

mikermcneil avatar Sep 13 '21 17:09 mikermcneil

When doing this, we need to be careful to communicate that revoking the enroll secret may effect any other host that uses the same enroll secret.

zwass avatar Sep 13 '21 17:09 zwass

Should we suggest revoking that other id instead of the enroll secret?

mikermcneil avatar Sep 21 '21 02:09 mikermcneil

@mikermcneil what do you mean by "that other id"? I think you're probably referring to the "node key" which is what gets revoked if someone confirms the delete here. But as long as the host is still online and the "enroll secret" is still valid, it will just exchange the enroll secret for a new node key.

zwass avatar Sep 21 '21 16:09 zwass

Should "or revoke the host's enroll secret" be removed from this modal on the host details page? This copy is different from the manage host page delete modal below:

Screen Shot 2022-09-22 at 2 50 30 PM

I think there was a discussion that we do not keep track of what secret a host used to enroll so it would be difficult to tell the user to delete that host's enroll secret.

RachelElysia avatar Sep 22 '22 19:09 RachelElysia

@RachelElysia FYI this issue tracks the request you brought to product office hours on 2022-09-29.

noahtalerman avatar Oct 03 '22 14:10 noahtalerman

@RachelElysia, I'm assigning this ticket to you for specifications.

lukeheath avatar Oct 03 '22 18:10 lukeheath

Removing this from the roadmap board in favor of https://github.com/fleetdm/fleet/issues/8206

zhumo avatar Oct 18 '22 20:10 zhumo

Removing this from the roadmap board in favor of https://github.com/fleetdm/fleet/issues/8206. @noahtalerman

zhumo avatar Oct 18 '22 20:10 zhumo

@lukeheath heads up, product would like to prioritize this issue.

Because it's estimated, I moved the issue to the estimated column in the roadmap board (bottom of the column).

noahtalerman avatar Dec 06 '22 16:12 noahtalerman

@lukeheath I moved this to the release board as an easy win for the day

RachelElysia avatar Dec 15 '22 21:12 RachelElysia