fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Published 20 hours ago • verified publisher icon fleetdm

Support drag and drop file uploads

Open lukeheath opened this issue 1 year ago • 1 comments

Goal

User story
As a Fleet user,
I want to drag and drop files to upload them
so that I don't have to use the file picker.

Context

  • Requestor(s): @lukeheath
  • Product designer: _________________________

Changes

Product

  • [ ] UI changes: TODO

Engineering

  • [ ] Implement code changes in Fleet UI. (Started at https://github.com/fleetdm/fleet/pull/19086)

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Risk level: Low

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. [ ] Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.

lukeheath avatar May 17 '24 20:05 lukeheath

Conversation about supporting multiple file uploads at once in the PR here: https://github.com/fleetdm/fleet/pull/19086#issuecomment-2124831396

noahtalerman avatar May 22 '24 13:05 noahtalerman

@noahtalerman Was this not prioritized because we don't want the feature, or because I need to update the PR to match Mike T.'s designs? Happy to update, just want to make sure it's something we actually want first.

lukeheath avatar Jun 04 '24 23:06 lukeheath

@lukeheath we want it! Just don't have design capacity:

  • We want to make sure Mike T's designs are melded w/ current UI style guide. Mike T has some future stuff in there (ex. modals)
  • We want a good error message if the user tries to upload more than 1 file. Why not start with multi-file upload? We don't support it today. So just adding drag and drop for 1 file is the quick iterative change.

Want to take it and bring it through design review?

noahtalerman avatar Jun 05 '24 22:06 noahtalerman

@noahtalerman Got it. Sure! I'll assign myself as product designer and bring this through a future design review.

lukeheath avatar Jun 07 '24 17:06 lukeheath

@eugkuo I think this is your #28462 request as well

RachelElysia avatar Apr 23 '25 13:04 RachelElysia

@RachelElysia And so it is! So what's the process here?

eugkuo avatar Apr 23 '25 13:04 eugkuo

@RachelElysia @eugkuo Looks like this fell off the radar. I'll close this one out in favor of @eugkuo's. I'll add a link to my PR POC as a reference for whoever ends up implementing.

lukeheath avatar Apr 23 '25 15:04 lukeheath

Drag, drop, files flow, Ease as leaves in the wind blow, Effortless work's glow.

fleet-release avatar Apr 23 '25 15:04 fleet-release