Post-story cleanups and finalization tasks
E.g. missing integration tests and other more minor but still important things:
-
From E2E test, installer filename overflows the modal page when a very long name is used (same in the output section if there are long unbreakable lines, see second video), see loom video:
- https://www.loom.com/share/dcb63c5abde542dd91c50191156415ea?sid=6dccf421-71e4-4f70-81d6-fe9fa1e42d0e
- https://www.loom.com/share/2307e9a6405042d7a4fc36b90b11c1b0?sid=b9e766fa-2071-4c19-8de6-931e85c35971
-
refine/troubleshoot package info extraction for our "marquee" apps (ones where we display the actual logo instead of a generic icon), for example, trying to upload an older Firefox package led to this situation:
-
modify orbit endpoint to download software to provide a checksum of the file, and update the orbit loop to make use of it.
-
Add .exe/.msi/.pkg assets for integration tests: https://github.com/fleetdm/fleet/blob/a564eeb51d30b050b62e3590e11c6ab859e7f16b/server/service/integration_enterprise_test.go#L9016-L9017
Backend Tasks: In progress
Martin part 1: https://github.com/fleetdm/fleet/pull/18955
- [x] Martin: https://github.com/fleetdm/fleet/pull/18676/files/e10bb3560a396b8a896235353e572186b35ed873#diff-bbd0c5a6bc2f9a24e633031d4c6a3f5b0be7cbfe78ef1b56cdf9a7a2c32e21e2R8645
- [x] Martin (might already be done, to verify): https://github.com/fleetdm/fleet/pull/18660/files#diff-b3883848dac3454f4ed4968a94f9ca335241f9f99bfad92f95a6bfb7157523ebR28-R29 (done in https://github.com/fleetdm/fleet/pull/18876/files#diff-b3883848dac3454f4ed4968a94f9ca335241f9f99bfad92f95a6bfb7157523ebR313 by Roberto)
- [x] Martin (I think it's already done, to verify): https://github.com/fleetdm/fleet/pull/18676/files/8618e6effc593d455b4143651b1b0dbee1e9c325#diff-4fe70646343c5f7a1b61dd6906889113f0e0ae63f684ab74a617acecb39fe6d3R1844-R1856 (was already addressed: https://github.com/fleetdm/fleet/blob/413be14d26c8c283248f65cc236a6c5b7bbed4be/server/datastore/mysql/software.go#L1854-L1859)
- [x] Martin: https://github.com/fleetdm/fleet/pull/18689/files#diff-bbd0c5a6bc2f9a24e633031d4c6a3f5b0be7cbfe78ef1b56cdf9a7a2c32e21e2R8656 (was already addressed)
- [x] Martin: dedupe computed software installer status reusable query (such as https://github.com/fleetdm/fleet/blob/cf28025af84f401032f83a34842678b0ff73b5f9/server/datastore/mysql/software.go#L1726 , https://github.com/fleetdm/fleet/blob/cf28025af84f401032f83a34842678b0ff73b5f9/server/datastore/mysql/software_installers.go#L328 and https://github.com/fleetdm/fleet/blob/cf28025af84f401032f83a34842678b0ff73b5f9/server/datastore/mysql/software_installers.go#L365)
- [x] Martin: Move software installer integration tests to "Enterprise" suite, from "MDM".
Martin part 2: https://github.com/fleetdm/fleet/pull/18982
- [x] Martin: test for invalid orbit tokens https://github.com/fleetdm/fleet/pull/18693#discussion_r1588239056
- [x] Martin: dedupe GetSoftwareInstallerForTitle (see https://github.com/fleetdm/fleet/pull/18780/files#r1592414093)
- [x] Martin: use datastore methods to insert software installers in server/datastore/mysql/software_installers_test.go
- [x] Martin: More integration test TODOs: https://github.com/fleetdm/fleet/blob/a564eeb51d30b050b62e3590e11c6ab859e7f16b/server/service/integration_enterprise_test.go#L9239-L9242
Roberto
- [x] * Add
counttop-level field to the response payload of "list software by host" endpoint (and "list software for my device" too): https://github.com/fleetdm/fleet/pull/17865/ https://github.com/fleetdm/fleet/pull/18995/
FE Tasks: In progress -- Sarah
- [x] Host software table status tooltip is missing arrow
- [x] Update UI for hosts without fleetd installed (https://fleetdm.slack.com/archives/C03C41L5YEL/p1715616069923329?thread_ts=1715366954.809189&cid=C03C41L5YEL)
- [x] Hide columns in host software table at smaller screen sizes
- [x] POST hosts/:id/software/install/:id not installing
- [x] change download link to button on SoftwarePackageCard. doesnt seem to be working with anchor tag because we need an authorization header.
- [x] refetch software title details when deleting software package
- [x] host filtering by software install status
- [x] performance issues on host details software tables when showing software details.
- [x] check that advanced options modal shows the install script
- [x] integration of install results into host software show details modal
- [x] In host details > software, clicking on a software title row should include the
team_idquery param in the URL
not sure if we need to do. Ask design
- confirm that GET /software/titles returns all data needed to show the icon in SoftwareNameCell
- add truncation to name and version cells of the host software table
- actions dropdown overflow styling issues (if the table is overflow-x: scroll then the actions dropdown menu gets clipped at the bottom of the table)
- remove unneeded action column border on host software table? (we dont do this on user or team tables)
- make action dropdown appear on hover? (we dont do this on user or team tables)