fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Website: Add tooltips to features on the pricing page

Open eashaw opened this issue 1 year ago • 2 comments

Closes: https://github.com/fleetdm/confidential/issues/4864

Changes:

  • Added tooltips to the features table on the pricing page.

eashaw avatar Mar 04 '24 23:03 eashaw

@mike-j-thomas FYI: The mobile tooltip icons are not buttons, and the "learn more" link is clickable inside the tooltip. I did this to prevent users from opening the link when they try to display the tooltip.

eashaw avatar Mar 04 '24 23:03 eashaw

@mike-j-thomas FYI: The mobile tooltip icons are not buttons, and the "learn more" link is clickable inside the tooltip. I did this to prevent users from opening the link when they try to display the tooltip.

@eashaw, gotcha, because there is no hover state on mobiles. However, during my testing on iOS, tapping the link dismisses the tooltip and does not open the link.

https://github.com/fleetdm/fleet/assets/78363703/74cd2a6f-4308-46fc-8eb4-4ffab22bcd04

mike-j-thomas avatar Mar 05 '24 01:03 mike-j-thomas

Hey @eashaw, thoughts on changing mobile behavior to open the tooltip as a modal? That way, we can include a close button to dismiss.

https://github.com/fleetdm/fleet/assets/78363703/5fbe9e22-daa8-4daf-99fd-6a4116a1268c

Please let me know what implications this would have on the code, if any, and whether it requires significant extra effort. Otherwise, I think we should go live with mobile tooltips disabled for the time being. I looked at a handful of sites, and it seems they are either disabled on mobile or broken. The ones that I saw working were opened as modals.

mike-j-thomas avatar Mar 08 '24 04:03 mike-j-thomas

@mike-j-thomas 👍 I updated this PR to have the mobile tooltips open in modals.

eashaw avatar Mar 08 '24 16:03 eashaw

@mike-j-thomas I'm going to merge this PR, I QA'd these changes on the earliest supported mobile devices/browsers on BrowserStack.

eashaw avatar Mar 08 '24 16:03 eashaw