fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Error message is too Windows specific when MDM profile type can't be determined

Open jahzielv opened this issue 11 months ago • 3 comments

Fleet version: <!-- Copy this from the "My account" page in the Fleet UI, or run fleetctl --version -->

Web browser and operating system:


💥  Actual behavior

When an MDM profile's target OS can't be determined, we return an error that is Windows specific:

Windows configuration profiles can only have <Replace> or <Add> top level elements.

🧑‍💻  Steps to reproduce

  1. Create a MacOS profile
  2. Remove the first 2 lines from the profile
  3. Attempt to upload the profile via fleetctl
  4. Note the error that comes back

🕯️ More info (optional)

Was brought up while working on #16335.

For more context see Slack thread.

jahzielv avatar Mar 01 '24 22:03 jahzielv

I’m in favor of updating the validation to assume .mobileconfig is macOS only and .xml is Windows only.

noahtalerman avatar Mar 04 '24 15:03 noahtalerman

@georgekarrv should this be on MDM board?

sharon-fdm avatar Apr 18 '24 13:04 sharon-fdm

@georgekarrv @jahzielv It Looks like this bug was missed; please prioritize when possible since it's old.

lukeheath avatar May 15 '24 23:05 lukeheath

Cloud city's code speaks, A message clear for all OS, Fleet's embrace widens.

fleet-release avatar Jun 21 '24 00:06 fleet-release