fleet icon indicating copy to clipboard operation
fleet copied to clipboard

add support for a min node and yarn version

Open ghernandez345 opened this issue 1 year ago • 2 comments

Adds a minimum supported node and yarn version to the project.

Currently if you are on an unsupported version of node or yarn, there is no messaging telling you that is the issue. The build just fails, and you are left to figure out it's because of your node version. With this change, it will be much clearer why any of the node required commands (e.g. make deps, make generate-dev, make lint-js, make test-js) are not working, and it will tell you exactly which minimum version of node or yarn you need.

After the console error is clear about using an unsupported node version

image

  • [x] Changes file added for user-visible changes in changes/ or orbit/changes/.
  • [x] Manual QA for all new/changed functionality

ghernandez345 avatar Feb 27 '24 13:02 ghernandez345

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.48%. Comparing base (2d1caa8) to head (87b230a). Report is 133 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17205   +/-   ##
=======================================
  Coverage   65.48%   65.48%           
=======================================
  Files        1190     1191    +1     
  Lines      106956   106964    +8     
  Branches     2569     2569           
=======================================
+ Hits        70039    70048    +9     
+ Misses      31581    31580    -1     
  Partials     5336     5336           
Flag Coverage Δ
frontend 52.10% <ø> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 04 '24 17:03 codecov[bot]

@ghernandez345 Re: This slack thread, we should update our prettier ruleset to define how we want to format YAML and then apply to all workflows.

The same thing happens when I save; I've meant to bring it up for a while. We can use this PR as an opportunity to do that.

lukeheath avatar Mar 04 '24 20:03 lukeheath

@ghernandez345 Re: This slack thread, we should update our prettier ruleset to define how we want to format YAML and then apply to all workflows.

The same thing happens when I save; I've meant to bring it up for a while. We can use this PR as an opportunity to do that.

@lukeheath Sounds good, but I think we should have it in a separate PR. I want to be able to revert the node version changes if we need to for any reason but wouldn't want to revert the prettier updates for YAML. I'll create a PR for the prettier formatting and link to it here. I'll also include a precommit hook for prettier so that it works even if people don't have the extension enabled in their editor.

ghernandez345 avatar Mar 05 '24 11:03 ghernandez345