Puppet module might unintentionally remove profiles from a team if one or more `/preassign` call fails but the `/match` succeeds

[roperzh]

Fleet version: 4.44.1, Puppet module: 0.2.3

---

💥  Actual behavior

Some profiles were removed from a team.

🧑‍💻  Steps to reproduce

1. Assign 3 profiles to a team
2. Make a Puppet run succeed
3. Make another Puppet run, but this time force a failure in one or more preassign API calls
4. Observe how the profiles are removed

🕯️ More info (optional)

The inner workings of the Puppet module are described here

[sharon-fdm]

@georgekarrv, this was caught in the NO-TEAM-SEARCH query. Add mdm label?

[roperzh]

@sharon-fdm yes, thanks and sorry for missing it!

[roperzh]

thanks to @sabrinabuckets we found an issue with the current implementation, pulling from "Awaiting QA" until it's fixed

[roperzh]

@sabrinabuckets a fix has been merged, moving this back to the QA column, sorry for the inconvenience! 🙏

[sabrinabuckets]

@roperzh perfect! I will find a time for us to re-test!

[sabrinabuckets]

Paired with Roberto to reproduce original issue and verify fix.

[fleet-release]

I couldn't think of a haiku this time. (See fleetdm.com logs for more information.)