fleet icon indicating copy to clipboard operation
fleet copied to clipboard

Published 20 hours ago • verified publisher icon fleetdm

Add a capability to target all hosts on "No team" when performing a live query

Open Patagonia121 opened this issue 1 year ago • 5 comments

Goal

User story
As a user running a live query in the UI,
I want to target hosts on "No team".

Changes

Product

  • [ ] UI changes: Figma
  • [ ] Outdated documentation changes: Document all the REST API endpoints where you can currently filter by "no team" using team_id=0. Example: https://github.com/fleetdm/fleet/pull/16635

Engineering

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

Context

  • Requestor(s): @Patagonia121

QA

Risk assessment

  • Requires load testing: No

Manual testing steps

  1. Try API endpoint GET fleet/targets/count with team_id=0
  2. Try API endpoint POST fleet/queries/run (for async live queries) with team_id=0
  3. Try UI live query with 'No Team'
  4. Try the above endpoints with other queries (like other team_id values) to make sure existing functionality didn't break.

Testing notes

Confirmation

  1. [x] Engineer (@getvictor): Added comment to user story confirming successful completion of QA.
  2. [ ] QA (@____): Added comment to user story confirming successful completion of QA.

Patagonia121 avatar Jan 25 '24 20:01 Patagonia121

@noahtalerman @rachaelshaw we got feedback from the customer that they'd like to do this primarily in the UI, but having support in the API could be very useful as well.

Patagonia121 avatar Jan 29 '24 22:01 Patagonia121

BE Est. 2 FE Est. 2

sharon-fdm avatar Feb 07 '24 20:02 sharon-fdm

Since there were no subtasks created, I never saw this in my Ready column. The frontend portion won't make it into this release.

jacobshandling avatar Mar 04 '24 22:03 jacobshandling

^ possibly. I will try to get it done today.

jacobshandling avatar Mar 04 '24 23:03 jacobshandling

Okay, made it in after all.

jacobshandling avatar Mar 05 '24 00:03 jacobshandling

No docs needed.

@Patagonia121, heads up, this customer request was shipped in 4.47 :shipit:

@rachaelshaw when you get the chance, can you please file an issue to check if there are other API endpoints that allow filtering by team_id: 0? (aka No team)

noahtalerman avatar Mar 14 '24 18:03 noahtalerman

Live query expands, "No team" hosts in our hands, Fleet's reach now commands.

fleet-release avatar Mar 14 '24 18:03 fleet-release