Adjusting TextBlockTheme height does not reflect in block type.

[nialljawad96]

Steps to Reproduce

1. Adjust a TextBlockTheme. E.g.:

  lists: TextBlockTheme(style: const TextStyle(
                                  fontWeight: FontWeight.w400,
                                  height: 1.55,
                                  fontSize: 14
                              ), spacing: VerticalSpacing(

                              ), ),

2. See how a numbered list does not align with text.

Environment

• OS: Mac OS
• Flutter version 3.16.4
• Fleather version 1.13.2

[amantoux]

Thanks for bringing this up. We'll take a look

[nialljawad96]

@amantoux any news on this Alan?

[amantoux]

Sorry for the veery late reply @nialljawad96 will look into this

[amantoux]

@nialljawad96 can you please test on master and tell us if this solves your issue from your point of view? When height is greater than 1 there is still a slight (constant it seems) misalignment that needs to be addressed in a later PR. Feel free to close the issue or leave it open if you deem it necessary to fix the slight misalignment for your use case.

[nialljawad96]

@amantoux Sorry for the late reply. For the following themeData:

   lists: TextBlockTheme(style: const TextStyle(
            fontWeight: FontWeight.w400,
            height: 1.55,
            fontSize: 16,
          fontFamily: "inter",
        ), spacing: VerticalSpacing(

        ), ),
        paragraph: TextBlockTheme(style: const TextStyle(
            fontWeight: FontWeight.w400,
            height: 1.55,
            color: Colors.white,
            fontFamily: "inter",
            fontSize: 16
        ), spacing: VerticalSpacing(

        ),

There is still a misalignment:

However, if I reduce the fontSize of the lists theme to 14, the misalignment disappears. I'm doing this for now as a mitigation.

[amantoux]

Thank you @nialljawad96 We'll address that in a later PR