fleather icon indicating copy to clipboard operation
fleather copied to clipboard

Slow typing performance when approx 45k characters used within editor

Open nialljawad96 opened this issue 1 year ago • 1 comments

Steps to Reproduce

  1. Place 45000 characters into editor
  2. Type a sentence
  3. Observe lag and delay

Environment

  • MacOS
  • Flutter 3.16.4
  • Fleather version 1.13.2

nialljawad96 avatar Jan 25 '24 11:01 nialljawad96

@nialljawad96 thank you for pointing this out Indeed performance on large pieces of text hasn't been tested yet.

amantoux avatar Jan 25 '24 20:01 amantoux

Hi @nialljawad96, we have a PR (#408) that might fix this issue. Would you be able to test it and get back to us? You can use it like following:

dependency_overrides:
  parchment:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: perf/cache_offset_and_length_for_nodes
      path: packages/parchment
  fleather:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: perf/cache_offset_and_length_for_nodes
      path: packages/fleather

Amir-P avatar Aug 20 '24 20:08 Amir-P