flutter_map icon indicating copy to clipboard operation
flutter_map copied to clipboard

fix!: changed type of `tileSize` to integer

Open JaffaKetchup opened this issue 1 year ago • 1 comments

Fixes #1936.

There's no apparent reason that tileSize would be anything but an integer, since it is not possible to get tiles in fractional pixels. This PR relies on this assumption, and a different fix would be needed for #1936 if this assumption is not valid.

Note that this is breaking.

JaffaKetchup avatar Aug 05 '24 16:08 JaffaKetchup

We'll leave this to review and merge before a major upgrade.

JaffaKetchup avatar Sep 12 '24 18:09 JaffaKetchup

As a way of making this less breaking, you could deprecate tileSize for a tileDimension parameter?

TesteurManiak avatar Nov 03 '24 12:11 TesteurManiak

As a way of making this less breaking, you could deprecate tileSize for a tileDimension` parameter?

I don't see why that wouldn't work, I'd be happy to do that if you think that's better.

JaffaKetchup avatar Nov 12 '24 20:11 JaffaKetchup

I've done what @TesteurManiak suggested.

JaffaKetchup avatar Nov 17 '24 21:11 JaffaKetchup