flutter_map icon indicating copy to clipboard operation
flutter_map copied to clipboard

fix for flickering with fitbounds, moving calculations inside the lay…

Open ibrierley opened this issue 1 year ago • 2 comments

Fix for flickering with fitbounds, moving calculations inside the layoutBuilder…

ibrierley avatar Sep 25 '22 08:09 ibrierley

Possible fix for the flickering issue https://github.com/fleaflet/flutter_map/issues/1375. Note this PR will need to proper testing, as I don't experience the issue, so can't verify this properly.

I would also test things like reorientating the device, and on web and emulators as there may well be other issues introduced and this can be quite a fiddly one to fix.

ibrierley avatar Sep 25 '22 09:09 ibrierley

It's working fine for me

mohammedX6 avatar Sep 26 '22 06:09 mohammedX6

@ibrierley You happy for this to be merged?

JaffaKetchup avatar Oct 10 '22 20:10 JaffaKetchup

Yes, but as mentioned, I could never replicate the problem, so was hard to know if this has been properly tested. I think it would be good for someone else to test if they get the chance, otherwise just go for it.

ibrierley avatar Oct 11 '22 06:10 ibrierley

Ok. @stx Can you also give this a test when you get a moment please?

JaffaKetchup avatar Oct 11 '22 06:10 JaffaKetchup

@JaffaKetchup Sure thing. I'll take a look at this tomorrow.

stx avatar Oct 11 '22 07:10 stx

@JaffaKetchup @ibrierley Sorry for the delay. Tested this on web and mobile and took 60 FPS captures and went through it frame by frame and it looks fixed and side-effect free! Nice work.

stx avatar Oct 13 '22 22:10 stx