flutter_map icon indicating copy to clipboard operation
flutter_map copied to clipboard

fix for 1373, where bounds doesn't get updated after a mapController …

Open ibrierley opened this issue 1 year ago • 2 comments

For https://github.com/fleaflet/flutter_map/issues/1373

I think setState gets called, but the onPositionChanged gets called before _bounds is updated (inside build). I've also added an extra check for a valid bounds check to be called on a test new bounds (we don't want to update _bounds if the new position is erm out of bounds).

ibrierley avatar Sep 23 '22 20:09 ibrierley

If you're happy with this, I'll just approve it. Or I can test it tomorrow (but I haven't been keeping up with the conversation).

JaffaKetchup avatar Sep 23 '22 21:09 JaffaKetchup

Give it a day anyway, in case someone spots a flaw.

ibrierley avatar Sep 23 '22 21:09 ibrierley

@ibrierley You happy for this to be merged?

JaffaKetchup avatar Oct 10 '22 20:10 JaffaKetchup

Yes, lets update I guess, and fix if anyone screams.

ibrierley avatar Oct 11 '22 06:10 ibrierley