luwak icon indicating copy to clipboard operation
luwak copied to clipboard

Upgrade to lucene 7.5

Open romseygeek opened this issue 6 years ago • 6 comments

This PR is a bare-bones upgrade, with no attempt at removing deprecations or reimplementing stuff. All tests pass, but it would be good to get some idea of any performance implications of these changes, particularly around the Multipass presearcher.

Fixes #146

romseygeek avatar Nov 10 '18 17:11 romseygeek

cc @dcollins53 @mjustice3

romseygeek avatar Nov 10 '18 17:11 romseygeek

Hi - we have a project that is currently using Lucene 7.5.0 and just started looking at also using Luwak. Just out of curiosity, is it likely that this PR upgrading to 7.5 would move forward in the near future? Is anything major blocking the upgrade?

zcox avatar Dec 20 '18 22:12 zcox

Hi @zcox, thanks for pinging! The only blocker here really is a check on the performance implications of the change, but I definitely plan on doing a release of luwak that will include this PR early in the new year. Can you build off the branch for now?

romseygeek avatar Dec 21 '18 08:12 romseygeek

@romseygeek - sounds great, we can definitely build off of this branch for now.

zcox avatar Dec 21 '18 16:12 zcox

@romseygeek Any update here? We're currently using a custom build off this branch but of course would prefer to use a published version.

magro avatar Jan 24 '19 07:01 magro

@romseygeek Can we help with anything that blocks merging this or that's related to publishing a new version?

magro avatar Mar 12 '19 15:03 magro