mini_portile icon indicating copy to clipboard operation
mini_portile copied to clipboard

Emit warning when an insecure URL is used to download files

Open flavorjones opened this issue 9 years ago • 2 comments

I would like mini_portile to emit a warning message when it downloads files over 'http'. Something like this would be great:

WARNING: insecure source being used: #{url}

flavorjones avatar Aug 24 '15 13:08 flavorjones

This is what the digest value is for. So I think it would be better so print:

WARNING: insecure source being used: #{url} - Please define a MD5/SHA1/SHA256 digest value.

larskanis avatar Aug 24 '15 13:08 larskanis

Ah, I agree. We should only emit this type of warning if a checksum is not provided.

flavorjones avatar Aug 24 '15 13:08 flavorjones