angular2-notifications icon indicating copy to clipboard operation
angular2-notifications copied to clipboard

Published 20 hours ago • verified publisher icon flauc

Pass data to templates

Open WiseBird opened this issue 7 years ago • 14 comments

Added a way to pass arbitrary data to templates. Removed bypassSecurityTrustHtml for user-provided templates, its totally unsafe to use it. Fixed class for html inserted via innerHTML (from sn-content to sn-html).

WiseBird avatar Nov 14 '17 10:11 WiseBird

@flauc Hello, build failed but I believe the cause is not in the PR, please take a look.

WiseBird avatar Nov 14 '17 10:11 WiseBird

@flauc Could you please review this PR it's really holding me back.

WiseBird avatar Jan 10 '18 15:01 WiseBird

Hi @WiseBird, I'm sorry this is taking so long I'm very short on time recently. Will do my best to have it merged tonight.

flauc avatar Jan 24 '18 12:01 flauc

#deadproject

worthy7 avatar Mar 30 '18 06:03 worthy7

Feel free to look into the issue @Worthy7. Project is clearly not dead since owner just released v1.0.0 to fix a bug. He's doing this for free.

prcbass avatar Apr 15 '18 14:04 prcbass

True, I am thankful!

worthy7 avatar Apr 16 '18 01:04 worthy7

I am also looking forward to see this PR merged :) @WiseBird Please merge/rebase and push in order to have the failed checks gone..

cubidobusinesssolutions avatar Jul 13 '18 19:07 cubidobusinesssolutions

@cubidobusinesssolutions I switched to https://github.com/scttcper/ngx-toastr

WiseBird avatar Jul 16 '18 20:07 WiseBird

Any news on this feature? I need this pretty badly...

wlievens avatar Jul 19 '18 13:07 wlievens

This library looks nice and appreciate the effort that went into it but now we're after TemplateContexts we've got to transition to ngx-toastr.

Maybe it would be better for us all to focus our efforts on ngx-toastr (which even has ng7 support already) and add a deprecation notice on this project that points there?

intellix avatar Oct 20 '18 10:10 intellix

@flauc Any update on this feature/Pull request? I need this pretty badly...

wsh92 avatar Nov 12 '18 19:11 wsh92

@cubidobusinesssolutions I switched to https://github.com/scttcper/ngx-toastr

@WiseBird do ngx-toastr have template context feature?

wsh92 avatar Nov 12 '18 21:11 wsh92

@wsh92 Yes, but it uses different approach: you create custom component for notification and pass there any data you like.

WiseBird avatar Nov 14 '18 13:11 WiseBird

@WiseBird Thanks, it is working like charm:)

wsh92 avatar Nov 14 '18 16:11 wsh92