shisho icon indicating copy to clipboard operation
shisho copied to clipboard

feat: `filters` in `rewrite_options`

Open lmt-swallow opened this issue 3 years ago • 2 comments

Description

(WIP)

Checklist

  • [ ] I opened a draft PR or added the [WIP] to the title if my PR is not ready for review.
  • [ ] I have reviewed the code by myself.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have made corresponding changes to the documentation.
  • [ ] I have added tests enough to show how your code behaves and that your code works as expected.

Additional Notes

(WIP)

lmt-swallow avatar Nov 01 '21 17:11 lmt-swallow

✔️ Deploy Preview for cranky-fermi-e6c846 canceled.

🔨 Explore the source changes: 85ef7b4ec5bc02677464d51043a6956a744ad0f0

🔍 Inspect the deploy log: https://app.netlify.com/sites/cranky-fermi-e6c846/deploys/6182e3b7918c1b000753a076

netlify[bot] avatar Nov 01 '21 17:11 netlify[bot]

Codecov Report

Merging #115 (85ef7b4) into main (3ed9086) will decrease coverage by 3.82%. The diff coverage is 70.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   75.14%   71.32%   -3.83%     
==========================================
  Files          31       35       +4     
  Lines        1718     1984     +266     
==========================================
+ Hits         1291     1415     +124     
- Misses        427      569     +142     
Impacted Files Coverage Δ
src/cli/reporter.rs 0.00% <ø> (ø)
src/cli/reporter/json.rs 0.00% <0.00%> (ø)
src/cli/reporter/sarif.rs 0.00% <0.00%> (ø)
src/cli/subcommand/find.rs 0.00% <0.00%> (ø)
src/core/ruleset/filter.rs 26.47% <26.47%> (ø)
src/core/rewriter/node.rs 31.74% <31.74%> (ø)
src/core/ruleset/util.rs 40.00% <40.00%> (ø)
src/core/rewriter/builder.rs 55.97% <50.00%> (-10.70%) :arrow_down:
src/core/ruleset/constraint.rs 54.87% <54.87%> (ø)
src/core/matcher/item.rs 64.19% <64.18%> (-21.07%) :arrow_down:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ed9086...85ef7b4. Read the comment docs.

codecov-commenter avatar Nov 03 '21 19:11 codecov-commenter