xdg-desktop-portal icon indicating copy to clipboard operation
xdg-desktop-portal copied to clipboard

Add Qt annotations

Open pterror opened this issue 9 months ago • 2 comments

Tested both by adding all .xml interface files to a Qt project via qt_add_dbus_interface, and through meson test -C _build.

Two tests are failing, attached for posterity: testlog.txt They don't seem to be introduced by this PR though, as I can still reproduce them on the previous commit, even after a clean rebuild.

Note that Lockdown.xml still errors as its property names are kebab-cased instead of snake_cased, which Qt considers as invalid.

  • Add missing Qt type annotations for complex types
  • Reorder Qt type annotations to the line above their corresponding parameters for consistency
  • Fix incorrect argument names

Also does minor formatting changes for consistency:

  • Prefer double quotes over single quotes
  • Prefer type= before name=

pterror avatar Apr 28 '24 17:04 pterror