xdg-desktop-portal
xdg-desktop-portal copied to clipboard
flatpak
Introduce XDP_APP_INFO_KIND_CONTAINERS1 which gets all information from D-Bus
Get the org.fdo.DBus.Containers1 idea rolling!
flatpak: https://github.com/flatpak/flatpak/pull/5656 dbus: https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/449
This falls back to the PID based lookup (flatpak/snap) if D-Bus doesn't support the new interface.
Remaining issues, everything else is supposed to work:
- Remapping paths (xdp_app_info_remap_path, xdp_app_info_get_path_for_fd) is not supported
- Dynamic Launcher's TryExec (xdp_app_info_get_tryexec_path) is not supported
Should be ready for review.
Made the commit messages much more useful and addressed the review.
Who is the person I should nag for a review then?
Who is the person I should nag for a review then?
Please be patient, I will get to this when I can. Nagging potential reviewers is likely to be counterproductive.
@swick thanks. I was going to mention @smcv , but since they're already aware of this PR, let's wait for their review.
Tried to pull out the non-Containers1 bits to https://github.com/flatpak/xdg-desktop-portal/pull/1281.
Turns out a few things can't really be expressed with just some key value pairs, such as path remapping and the details of installing dynamic launchers. I'm going to use the metadata to pass a bus and object which implements a common Contaienrs1 interface. Flatpak then implements this interface in the flatpak-session-helper and x-d-p can offload the functionality there.