libportal icon indicating copy to clipboard operation
libportal copied to clipboard

Redundant parameter in SaveFiles() method from FileChooser portal

Open grulja opened this issue 6 years ago • 2 comments

In xdp_portal_save_files() users might pass current_name parameter, but this one is not mentioned in xdg-desktop-portal documentation and doesn't seem to make sense in this call as you are saving multiple files at once.

grulja avatar Feb 07 '20 13:02 grulja

This probably cannot be solved (removed) at this moment as it would break API for those using it already. On the other hand I don't expect many apps using it yet, especially the xdp_portal_save_files() function so perhaps it's safe to remove it in this early stage? It probably won't cause any harm having it there, it's just it might be confusing for someone.

grulja avatar Feb 11 '20 09:02 grulja

@mjog wrote the SaveFiles functionality IIRC.

hadess avatar Mar 26 '20 14:03 hadess