flatpak-github-actions icon indicating copy to clipboard operation
flatpak-github-actions copied to clipboard

Allow configuring verbose mode?

Open olof-nord opened this issue 2 years ago • 3 comments

Hello!

When using flatpak/flatpak-builder I find it useful to provide verbose output using the --verbose flag.

What do this project think about allowing to specify this also through this GitHub action?

        with:
          verbose: true

If this is per default set to false, I argue this would be a fully backwards compatible addition.

Adding support for it should not be too complicated: I suspect we need one more if check with an args.push in flatpak-builder:index.js for the build function, and then just update the arguments and documentation.

olof-nord avatar Aug 31 '22 07:08 olof-nord

Looking at the recent commits, I suspect it could be done in a way similar to the addition of the mirrorScreenshotsUrl argument.

Edit: with the ok I volunteer to put together a PR suggesting how to implement this myself. The main question here is if this additional feature fits into the scope set out for this project.

olof-nord avatar Aug 31 '22 07:08 olof-nord

Should be done as part of #59

bilelmoussaoui avatar Aug 31 '22 07:08 bilelmoussaoui

Excellente. Many thanks for the fast (instant!) feedback @bilelmoussaoui.

olof-nord avatar Aug 31 '22 07:08 olof-nord