flatpak-github-actions
flatpak-github-actions copied to clipboard
ci: migrate to GitHub Container Registry
Migrate the container images from DockerHub to GitHub's container registry.
This pull request also bumps the related Docker GitHub Actions and makes the source of Fedora's base image explicit.
fixes #60
I believe this is all correct. Note that the Flatpak Builder test can't succeed until the PR is actually merged, because the images aren't available until after (See: successful test in my fork).
The worflows use github.actor
and github.repository
in some places (rather than bilelmoussaoui
), to allow contributors to have those images build/push in their forks. This shouldn't pose any problems for the distributed GitHub Actions, though.
So before we actually land this one, I think we should ship one single image that provides the basic tools to build/deploy a flatpak application without any pre-configured remotes. Then flathub could provide a set of images itself that contains the various SDKs combinations that would be built on top of the basic image provided by the actions itself.
We would still document the availabilities of such images in the readme as well as keep the current images up to date for a while, so I would add a new job instead of modifying current ones.
As we moved to the flatpak namespace, i want to keep it clear that flatpak is not tied to flathub and can be used with other remotes if desired.
So before we actually land this one, I think we should ship one single image that provides the basic tools to build/deploy a flatpak application without any pre-configured remotes.
So I guess what you mean is more or less the Dockerfile
in the root directory, but basically just a baredbones ontop of fedora:latest
?
FROM registry.fedoraproject.org/fedora:latest
RUN dnf update -y && \
dnf install -y flatpak flatpak-builder python3-aiohttp python3-tenacity python3-gobject xorg-x11-server-Xvfb ccache zstd && \
dnf clean all
ADD https://raw.githubusercontent.com/flatpak/flat-manager/master/flat-manager-client /usr/bin
RUN chmod +x /usr/bin/flat-manager-client
If so, I can open a PR with a new Dockerfile
and workflow that pushes it to ghcr.io. Or did you mean the existing image as-is, just with no SDKs actually installed?
Okay, closing this one in favour of #101.