flatpak-github-actions icon indicating copy to clipboard operation
flatpak-github-actions copied to clipboard

Published 20 hours ago • verified publisher icon flatpak

Include ".flatpak" suffix in artifact name to avoid conflicts with other artifacts

Open darkdragon-001 opened this issue 1 year ago • 6 comments

This is necessary as we remove the .flatpak suffix when adding the arch suffix. In workflows where one also builds other artifacts this name might conflict otherwise and it is obvious for users that app-ARCH is supposed to contain Flatpak bundles.

darkdragon-001 avatar Jan 22 '24 08:01 darkdragon-001

@bilelmoussaoui friendly ping

darkdragon-001 avatar Feb 12 '24 07:02 darkdragon-001

The changes in the commit are not enough. Please see the contributing guidelines

bilelmoussaoui avatar Feb 12 '24 07:02 bilelmoussaoui

@bilelmoussaoui Thanks, I updated the dist file. Could you please have another look?

darkdragon-001 avatar Feb 12 '24 19:02 darkdragon-001

@bilelmoussaoui Is anything else missing from my side?

darkdragon-001 avatar Feb 14 '24 20:02 darkdragon-001

@barthalion applied this at https://github.com/flathub-infra/flatpak-github-actions/commit/5ca63117633f03769aa13bd99525e93de90deb60

darkdragon-001 avatar Feb 17 '24 07:02 darkdragon-001

Added to https://github.com/flathub-infra/flatpak-github-actions/commit/5ca63117633f03769aa13bd99525e93de90deb60

darkdragon-001 avatar Feb 22 '24 13:02 darkdragon-001