flatpak-github-actions icon indicating copy to clipboard operation
flatpak-github-actions copied to clipboard

Switch Docker image to use Flathub's flatpak-builder-lint

Open barthalion opened this issue 1 year ago • 6 comments

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

barthalion avatar Dec 12 '23 14:12 barthalion

This image switch look like it will breaks CIs (actions consumer) that relies on dnf to install some tools which is a big issue.

Images on Docker Hub should not have such a breakage.

Edit: It can be good base image for Github registry images (#60).

tytan652 avatar Dec 12 '23 15:12 tytan652

The fact dnf was available was at best an implementation detail, and not something action users should rely on in the first place.

barthalion avatar Dec 12 '23 15:12 barthalion

This way, all tools match the one used on Flathub infra, and reduce potential breakage caused by Fedora bumping packages.

Isn't org.flatpak.Builder going to do the same when it will bump flatpak-builder to 1.4 ? Yes, less frequently but it still can happen.

tytan652 avatar Dec 12 '23 17:12 tytan652

It's obviously not being bumped to 1.4 until it's actually functional.

barthalion avatar Dec 12 '23 17:12 barthalion

Note that I am not a fan of tying the base image with flathub infrastructure and decisions. so please don't merge this until we figure out a way to split the base image provided by the flatpak action and flathub specific bits

bilelmoussaoui avatar Dec 12 '23 17:12 bilelmoussaoui

Until this is resolved one way or another, I will be maintaining a soft fork at https://github.com/flathub-infra/flatpak-github-actions/.

barthalion avatar Dec 15 '23 13:12 barthalion