flatpak-github-actions icon indicating copy to clipboard operation
flatpak-github-actions copied to clipboard

Update screenshot location to builddir/files/share/app-info/media

Open bbhtt opened this issue 1 year ago • 2 comments

See https://github.com/flatpak/flatpak-github-actions/issues/168

The location was changed in the libappstream port of flatpak-builder

https://github.com/flatpak/flatpak-builder/commit/411da7541456b7acea64d5edf1e68386b2eeb0ea

bbhtt avatar Dec 11 '23 03:12 bbhtt

The contents of the two directories are different btw.

> tree _build/files/share/app-info/media/
└── com
    └── viber
        └── Viber.desktop
            └── 57afa5ae90ff56ff22f259783cfd3c37
                ├── icons
                │   └── 128x128
                │       └── com.viber.Viber.desktop.png
                └── screenshots
                    ├── image-1_224x214.png
                    └── image-1_orig.png
> tree _build2/screenshots/
└── com.viber.Viber-master
    ├── 112x63
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    ├── 1248x702
    ├── 1504x846
    ├── 224x126
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    ├── 624x351
    │   └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png
    └── 752x423
        └── com.viber.Viber-29b4518dc53f788e03cacc3f0bb323bc.png

TingPing avatar Feb 21 '24 19:02 TingPing

It should work fine, appstream now generates the urls in catalogue as /media/com/viber/<hash>/screenshot/<image>

bbhtt avatar Feb 22 '24 02:02 bbhtt