flatpak-builder: Add --socket=session-bus if tests are enabled

[tchx84]

TLDR: Now that this action supports DBus for tests, I am trying to switch to it for Flatseal, but I can't seem to make it work.

I haven't really found the issue yet, but, while trying to mimic what this action does locally, I noticed I had to add to --socket=session-bus to the tests-args in my manifest to make it work. So, I am putting this here in case it's really needed.

See https://github.com/tchx84/Flatseal/pull/514

[bilelmoussaoui]

I would expect people to set test-args on their upstream manifests for any needs they might have. The ones we have are the "most important" and common ones

[tchx84]

I would expect people to set test-args on their upstream manifests for any needs they might have. The ones we have are the "most important" and common ones

I would argue that, If the action features support for DBus tests, then the requirements for running DBus tests should be considered "important" as well, e.g, adding --socket=session-bus in this case.

Otherwise it's confusing.

[bilelmoussaoui]

Well, the action runs that for you as you need to get the returned dbus address and expose that as an env variable for the test environment. That is too much to handle from the app side compared to adding a test argument to the manifest.

Especially there are very few apps that requires dbus access for their tests.