flatpak-builder icon indicating copy to clipboard operation
flatpak-builder copied to clipboard

default strip-components:1 doesn't work for some archives, produces no error/warning

Open kparal opened this issue 8 years ago • 1 comments

If I use e.g. https://www.freefilesync.org/download/FreeFileSync_9.5_Source.zip as a source, there's no top level directory. However, flatpak-builders pick one and extracts only files below that, and throws away the rest. The compilation then fails, but it's really confusing for the user to figure out what's wrong.

I believe that if there are more top-level files in the archive than just a single directory, and the default strip-components value is used, it should rather generate a clear error so that the user knows to set strip-components value differently (or perhaps it could intelligently set the value to 0 in that case).

flatpak-builder-0.10.4-1.fc27.x86_64

kparal avatar Nov 29 '17 14:11 kparal

You've probably either solved it by now or created a workaround, however I've just stumbled upon this issue myself and I'd like to share a solution.

You could find in the man page for flatpak manifest (man flatpak-manifest) under section Sources, Archive sources (tar, zip) all available options. On of those options is strip-components with which you could easily change the strip level to zero and the issue is resolved.

Cheers!

dusansimic avatar Feb 06 '22 18:02 dusansimic